Moving the check "using_rocksdb_in_tests" on to rocksdb_config #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is logically where it belongs. Also this moves the check from the node library in to the nano_lib library. This addresses a circular reference where node code is referencing the test library.
clemahieu
force-pushed
the
move_rocksdb_check
branch
from
772d7fa
to
21b0e8d
Compare
…ibrary since it is a testing class. Also renaming file from testing.c/hpp to system.c/hpp to better represent what the file contains.
thsfs
reviewed
Jun 14, 2021
thsfs
approved these changes
Jun 14, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the check "using_rocksdb_in_tests" onto rocksdb_config, which is logically where it belongs. Also, this moves the check from the node library into the nano_lib library. This addresses a circular reference where test code is referencing the node library.