Fix for unit test bulk.offline_send #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test expected the ledger to be able to report a block as confirmed because the active transaction container was empty. But it has to allow for some time for the data/event to flow to the ledger. Converted an assert to an assert timely to allow for that propagation. This is the failure: [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from bulk [ RUN ] bulk.offline_send /home/ds/nano/branches/develop/nano-node/nano/core_test/bootstrap.cpp:1764: Failure Value of: node1->block_confirmed (send1->hash ()) Actual: false Expected: true terminate called after throwing an instance of 'testing::internal::GoogleTestFailureException' what(): /home/ds/nano/branches/develop/nano-node/nano/core_test/bootstrap.cpp:1764: Failure Value of: node1->block_confirmed (send1->hash ()) Actual: false Expected: true Aborted
thsfs
approved these changes
Jun 30, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test expected the ledger to be able to report a block as confirmed
because the active transaction container was empty. But it has to allow
for some time for the data/event to flow to the ledger.
Converted an assert to an assert timely to allow for that propagation.
This is the failure:
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from bulk
[ RUN ] bulk.offline_send
/home/ds/nano/branches/develop/nano-node/nano/core_test/bootstrap.cpp:1764: Failure
Value of: node1->block_confirmed (send1->hash ())
Actual: false
Expected: true
terminate called after throwing an instance of 'testing::internal::GoogleTestFailureException'
what(): /home/ds/nano/branches/develop/nano-node/nano/core_test/bootstrap.cpp:1764: Failure
Value of: node1->block_confirmed (send1->hash ())
Actual: false
Expected: true
Aborted