Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cleaning up genesis_dev constants #3383

Merged
merged 7 commits into from
Jul 21, 2021
Merged

Cleaning up genesis_dev constants #3383

merged 7 commits into from
Jul 21, 2021

Conversation

clemahieu
Copy link
Contributor

A number of constants used in unit testing are spread between ledger_constants and the nano:: namespace. Some are duplicated in testutil.hpp.

These changes unify the unit test constants under nano::dev.

@clemahieu clemahieu added this to the V23.0 milestone Jul 21, 2021
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and successfully compiled/ran tests locally

@clemahieu clemahieu merged commit 386ec4a into develop Jul 21, 2021
@clemahieu clemahieu deleted the genesis_dev_cleanup branch July 27, 2021 09:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants