Fix broken cli commands: wallet_create, wallet_list (issue #3447), diagnostics (issue #3452) and other CLI commands #3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nocurrency#3447) The node_wrapper was using dev network params instead of active network params. This caused some CLI commands (at least --wallet_create and wallet_list) to fail. To fix the bug, for now, I created a local copy of network_params in node_wrapper and initialise it with active_network. However, it would be better to have a network_param reference passed down so that we do not have multiple copies of network_params. I created an issue for that improvement: nanocurrency/nano-node-internalonly#73
Prints all ledger blocks to stdout in text form
The --initialize command initialises the data folder, if it is not already initialised. It creates a ledger file and adds the genesis block.
This was referenced Sep 21, 2021
zhyatt
added
the
documentation
clemahieu
approved these changes
Sep 22, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wallet_create and wallet_list CLI commands were broken. Probably many CLI commands were broken.
The problem was that inactive_node class only worked in dev network and inactive_node is used in a lot of CLI commands. In other words the CLI comamnds using inactive_node could not work in live, beta or test networks.
I fixed the diagnostics CLI command so that I could write a test script for the wallet commands.
I introduced the initialize CLI command to initialize the data folder, which was also need in order to write a test case for the wallet commands.
I introduced the CLI command debug_block_dump to print ledger blocks so that I can check that initialize commands works correctly for the different networks (live, beta, test).
@zhyatt , I introduces 2 new CLI commands "initialize" and debug_block_dump which we need to document.