Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix a couple issues found with TSAN and add a suppression for Crypto++ #3563

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Fix a couple issues found with TSAN and add a suppression for Crypto++ #3563

merged 2 commits into from
Nov 22, 2021

Conversation

clemahieu
Copy link
Contributor

No description provided.

@clemahieu
Fix issue identified with valgrind where priv_key starts uninitialized.
5a274cd
@clemahieu
Add suppressions for Rijndael::Base::FillEncTable and Rijndael::Base:…
5d369dd 
…:FillDecTable. There is a race condition when initializing these tables but since their contents is static, the fields will always have the correct, constant values.
@clemahieu clemahieu added this to the V23.0 milestone Nov 22, 2021
@clemahieu clemahieu added the bug label Nov 22, 2021
@clemahieu clemahieu merged commit cb87f07 into develop Nov 22, 2021
@clemahieu clemahieu deleted the sanitizer_fixes branch November 22, 2021 13:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@theohax theohax theohax approved these changes

@dsiganos dsiganos dsiganos approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
V23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clemahieu @dsiganos @theohax