Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update images for README and QT wallet to be new symbol #3586

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Update images for README and QT wallet to be new symbol #3586

merged 1 commit into from
Dec 21, 2021

Conversation

zhyatt
Copy link
Collaborator

@zhyatt zhyatt commented Dec 6, 2021

No description provided.

@zhyatt zhyatt added qt wallet Item related to the qt wallet non-functional change labels Dec 6, 2021
@zhyatt zhyatt requested a review from argakiig December 6, 2021 21:02
@dsiganos
Copy link
Contributor

dsiganos commented Dec 7, 2021

I built nano_wallet on linux and looked at it but I do not see any nano logos... what changed and where is it?

@zhyatt
Copy link
Collaborator Author

zhyatt commented Dec 7, 2021

@dsiganos Should be splash screen on load up of the QT wallet and app logo on the OS. @argakiig Can you verify those are the locations that you verified?

@argakiig
Copy link
Contributor

argakiig commented Dec 7, 2021

@dsiganos Linux associates the image external to the resulting binary, do you see It on the splash. @zhyatt can confirm the built binary on win had it as well as on the splash.

@dsiganos
Copy link
Contributor

dsiganos commented Dec 7, 2021

I do not see a splash image and I do not see any logos anywhere.

@clemahieu
Copy link
Contributor

I'm able to see the splash screen quickly on launch with the symbol.

@zhyatt
Copy link
Collaborator Author

zhyatt commented Dec 7, 2021

I do not see a splash image and I do not see any logos anywhere.

@dsiganos Are you seeing a splash screen on initial QT wallet startup that has the old logo or no logo?

@dsiganos
Copy link
Contributor

dsiganos commented Dec 8, 2021

I see something that looks like the borders of a splash screen for a second but it has no contents.
I hadn't even noticed it until now. So I think the splash screen doesn't show on my machine for some reason.
I didn't even know there was supposed to be a splash screen until now.

@zhyatt
Copy link
Collaborator Author

zhyatt commented Dec 8, 2021

I see something that looks like the borders of a splash screen for a second but it has no contents. I hadn't even noticed it until now. So I think the splash screen doesn't show on my machine for some reason. I didn't even know there was supposed to be a splash screen until now.

So you haven't previously seen a splash screen with other builds? Perhaps there is a longer standing issue with the splash screen on Linux not related to these simple image changes.

@dsiganos
Copy link
Contributor

dsiganos commented Dec 8, 2021

The effect I see (no splash screen, just the outline of a border) is not a regression.
The same things happens with V22.1.

@zhyatt
Copy link
Collaborator Author

zhyatt commented Dec 9, 2021

The effect I see (no splash screen, just the outline of a border) is not a regression. The same things happens with V22.1.

Ok thanks for confirming, I created another issue to tackle that. #3599

@clemahieu
Copy link
Contributor

It sounds like it's disappearing really quickly. Maybe the startup is just fast? We don't have a minimum time it stays up.

@zhyatt zhyatt merged commit 7b5907c into nanocurrency:develop Dec 21, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
non-functional change qt wallet Item related to the qt wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants