Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable batch of intermittently failing unit tests #3629

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

theohax
Copy link
Contributor

@theohax theohax commented Jan 3, 2022

Disabling a batch of failing unit tests:

  • distributed_work.peer_multi

  • votes.add_old_different_account

  • active_transactions.inactive_votes_cache_multiple_votes

  • confirmation_height.conflict_rollback_cemented

  • active_transactions.confirm_new

  • election.quorum_minimum_flip_success

  • rpc.work_peer_many

  • rpc.work_version_invalid

  • node.vote_by_hash_epoch_block_republish

  • rpc.work_peer_one

  • bootstrap_processor.lazy_unclear_state_link

  • node.pruning_age

  • wallet.process_block

@dsiganos
Copy link
Contributor

Most of these tests use scheduler flush so instead of disabling them, we should remove the need to use flush.

@theohax
Copy link
Contributor Author

theohax commented Jan 24, 2022

Most of these tests use scheduler flush so instead of disabling them, we should remove the need to use flush.

I would actually disable them and then start on fixing them, fixing is not always that trivial and might take quite some time for all of these.

@theohax theohax merged commit b2d43af into develop Jan 24, 2022
@theohax theohax deleted the disable-batch-failing-uts branch January 24, 2022 15:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug unit test Related to a new, changed or fixed unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants