Investigate and fix some of the disabled unit tests #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theohax
commented
Jan 18, 2022
|
|
||
| // TODO: investigate | ||
| // | ||
| // auto const confirm_req_count = election->confirmation_request_count.load(); |
There was a problem hiding this comment.
@clemahieu -- need a bit of help with this one. It fails randomly, but definitely reproducible. I'd actually say it fails more than it passes. Any thoughts why the confirmation requests wouldn't be seen?
thsfs
reviewed
Jan 24, 2022
This was
linked to
issues
Jan 26, 2022
Closed
|
@reviewers -- now ready for final review. |
dsiganos
approved these changes
Feb 2, 2022
|
Couple tests failed in the CI:
Merging this |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables back a bunch of tests that we have been disabling due to their intermittent failures.
Once the PR is ready for merging, I'll update the relevant GitHub issues as well.