Remove db templates #3783
Merged
Remove db templates #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntations for mdb and rocksdb.
zhyatt
added
the
quality improvements
|
Seems to be a good path to reduce complexity and enable further changes. |
thsfs
approved these changes
Apr 8, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch removes templates from the lmdb/rocksdb backend.
Templates were intended to reduce the amount of boilerplate code shared between different backends, however, backends infrequently had matching implementations making the template code confusing and unmaintainable.
This removes templates from the various block store classes and replaces it with simple inheritance.