Further removal of templates in db classes #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving function from store_partial. This is one of the leaky abstractions resulting from the former templated code. lmdb exposes return statuses with int while rocksdb uses an enum class. Removing the leaky abstraction will allow this code to be specialized to the backend type and flow more logically.
… Changing each to constexpr values.
…tics and this is how it's actually implemented.
…re_partial to nano::store.
thsfs
reviewed
Apr 11, 2022
| @@ -27,7 +28,7 @@ bool nano::lmdb::account_store::get (nano::transaction const & transaction, nano | |||
| void nano::lmdb::account_store::del (nano::write_transaction const & transaction_a, nano::account const & account_a) | |||
| { | |||
| auto status = store.del (transaction_a, tables::accounts, account_a); | |||
| release_assert_success (store, status); | |||
| store.release_assert_success (status); | |||
There was a problem hiding this comment.
I'd let this as a free function.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves methods off of store_partial and eliminates it.
Moves mdb_store/rocksdb_store in to their respective namespaces and renamed to store.