Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding details to the DB commit () release_asserts #3786

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Adding details to the DB commit () release_asserts #3786

merged 1 commit into from
Apr 12, 2022

Conversation

thsfs
Copy link
Contributor

@thsfs thsfs commented Apr 11, 2022

Just adds complementary info to the assertions. They will fail in case of the disk getting out of space.

Partially address: #3552

@zhyatt zhyatt added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Apr 11, 2022
@zhyatt zhyatt added this to the V24.0 milestone Apr 11, 2022
@thsfs thsfs merged commit cf5a088 into develop Apr 12, 2022
@thsfs thsfs deleted the lmdb_write_assert_details branch April 12, 2022 13:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

@dsiganos dsiganos Awaiting requested review from dsiganos

Assignees
No one assigned
Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thsfs @clemahieu @zhyatt