-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Changes the accounts_frontiers RPC to return per account results #3791
Conversation
7cae7fb
to
c4ca179
Compare
The "feature" where we correct accounts, sounds like an unnecessary complication that we should remove. |
In the
The But, in anyway, this PR is handling it correctly by using the requested account number ( |
Added a new unit test for it. |
A simpler test case for accounts_frontiers Co-authored-by: Dimitrios Siganos <dimitris@siganos.org>
2497b27
to
9295ddc
Compare
The previous implementation returned only an error result in case any of the accounts were invalid. This implementation now handles each account separately returning per account results. It returns an empty string when the account's frontier is zero, and returns an error message for when the provided account is invalid.
Example:
Reference issue: #3752