open_burn_account errors and comments
#3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparK-Cruz
approved these changes
May 3, 2022
| @@ -3312,6 +3312,9 @@ void nano::json_handler::process () | |||
| rpc_l->ec = nano::error_process::insufficient_work; | |||
| break; | |||
| } | |||
| case nano::process_result::opened_burn_account: | |||
There was a problem hiding this comment.
This helps a lot, the RPC caller knows what's up.
| @@ -455,7 +455,10 @@ nano::process_return nano::block_processor::process_one (nano::write_transaction | |||
| } | |||
| case nano::process_result::opened_burn_account: | |||
| { | |||
| node.logger.always_log (boost::str (boost::format ("*** Rejecting open block for burn account ***: %1%") % hash.to_string ())); | |||
| if (node.config.logging.ledger_logging ()) | |||
There was a problem hiding this comment.
always_log to try_log will decrease the log size in case of repeated attempts, I like it.
dsiganos
approved these changes
May 4, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While no private key exists for the burn address, one may still create valid signatures for this account by taking advantage of the fact that it's the 6th torsion of the zero point. As an example, here's a valid block to open the account.
{ "action": "process", "json_block": "true", "subtype": "open", "block": { "type": "state", "account": "xrb_1111111111111111111111111111111111111111111111111111hifc8npp", "previous": "0000000000000000000000000000000000000000000000000000000000000000", "representative": "nano_3mhrc9czyfzzok7xeoeaknq6w5ok9horo7d4a99m8tbtbyogg8apz491pkzt", "signature": "c9a3f86aae465f0e56513864510f3997561fa2c9e85ea21dc2292309f3cd60220200000000000000000000000000000000000000000000000000000000000000", "work": "2d217e0ef5bbbd29", "link": "ECCB8CB65CD3106EDA8CE9AA893FEAD497A91BCA903890CBD7A5C59F06AB9113", "link_as_account": "nano_3u8djku7snrifufastfcj6zyoo6qo6fwo63rk57xhbg7mw5cq6amt5a1zq14", "balance": "205676479000000000000000000000000000000" } }Right now the RPC returns
{ "error": "Error processing block" }Which is less specific than the
opened_burn_accountprocess error that induces it.This PR handles this case better by
opened_burn_accountthrough the RPCopened_burn_accountso as to reduce the noise potential should someone try publishing lots of these