New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix `server_socket` close method override #3853

Merged

clemahieu merged 1 commit into nanocurrency:develop from pwojcikdev:prs/fix-socket-close-override

Jul 9, 2022

Contributor

pwojcikdev commented Jul 9, 2022

This is a fix for a subtle bug I found. The close method of socket was not virtual so an override in server_socket had no effect.


          Fix server_socket close override

6649edc

pwojcikdev added the bug label

clemahieu approved these changes

View reviewed changes

clemahieu merged commit 858d074 into nanocurrency:develop

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

bug