-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add populate_backlog
rpc command
#3860
Merged
pwojcikdev
merged 15 commits into
nanocurrency:develop
from
pwojcikdev:populate-backlog-rpc
Jul 20, 2022
Merged
Add populate_backlog
rpc command
#3860
pwojcikdev
merged 15 commits into
nanocurrency:develop
from
pwojcikdev:populate-backlog-rpc
Jul 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
reviewed
Jul 15, 2022
pwojcikdev
force-pushed
the
populate-backlog-rpc
branch
from
July 15, 2022 18:07
97e001c
to
78d169c
Compare
dsiganos
reviewed
Jul 19, 2022
dsiganos
added
the
documentation
This item indicates the need for or supplies updated or expanded documentation
label
Jul 19, 2022
pwojcikdev
force-pushed
the
populate-backlog-rpc
branch
from
July 20, 2022 08:25
089f8e5
to
7866883
Compare
dsiganos
previously approved these changes
Jul 20, 2022
It is not immediately obvious that the trigger can be used even when backlog population is disabled and that it is used for manual triggering mainly.
Introduce the class nano::backlog_population::config to hold the configuration items and not need access to nano::nodeconfig.
dsiganos
previously approved these changes
Jul 20, 2022
dsiganos
approved these changes
Jul 20, 2022
qwahzi
added a commit
to qwahzi/nano-docs-1
that referenced
this pull request
Jan 24, 2023
Adding populate_backlog rpc command documentation, per nanocurrency/nano-node#3860
thsfs
added a commit
to nanocurrency/nano-docs
that referenced
this pull request
Jan 26, 2023
* Update rpc-protocol.md with populate_backlog command Adding populate_backlog rpc command documentation, per nanocurrency/nano-node#3860 * Update populate_backlog in rpc-procotol.md Changing the language from "5 minute intervals" to something more generic, to account for potential interval changes in the node in the future. Co-authored-by: qwahzi <qwahzi@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
documentation
This item indicates the need for or supplies updated or expanded documentation
enhancement
rpc
Changes related to Remote Procedure Calls
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new rpc command for populating backlog. Populating backlog is a process in the node that scans all accounts , checks for unconfirmed blocks in that account's chain and queues those blocks for confirmation via election scheduler. I found this command to be very useful when setting up local test networks, as by default backlog population is done in 5 minute intervals which is too slow. It is no doubt that a better way for scheduling the backlog population would be a better long term solution, but I think a manual way to trigger that is nevertheless very useful.
Request:
{ "action": "populate_backlog" }
Response:
{ "success": "" }