Improved inactive_vote_cache
#3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
prs/extract-vote-cache
branch
from
c54c8c6
to
28eccf7
Compare
dsiganos
reviewed
Aug 26, 2022
nano/node/vote_cache.hpp
Outdated
|
|
||
| mutable nano::mutex mutex; | ||
|
|
||
| friend std::unique_ptr<nano::container_info_component> collect_container_info (active_transactions &, std::string const &); |
dsiganos
previously approved these changes
Aug 26, 2022
dsiganos
approved these changes
Aug 27, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts and improves
inactive_vote_cachewhich is responsible for storing votes that do not correspond to any currently active election. It contains logic for sorting block hashes according to the amount of tally from stored votes which will enable prioritization of hinted elections in the future.When running tests there might be some errors, but I already addressed them in separate PRs:
#3905
#3906