Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change election scheduler to consider previous balance #4022

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

clemahieu
Copy link
Contributor

This change teaches the election scheduler to consider both the previous and new balance when scheduling a block. With this change if an account sends its entire balance, the transaction will not be placed in the lowest priority bucket.

…revious block's balances and prioritize to the max of both.
…accept the priority value in prioritization::push.
@clemahieu clemahieu merged commit c96f37b into nanocurrency:develop Dec 9, 2022
clemahieu added a commit that referenced this pull request Dec 9, 2022
* Teach the scheduler priority queue to consider both the block's and previous block's balances and prioritize to the max of both.
* Move priority calculations in to the election_scheduler and directly accept the priority value in prioritization::push.
@qwahzi qwahzi added this to the V24.0 milestone Dec 29, 2022
mistakia pushed a commit to mistakia/nano-community that referenced this pull request Jan 3, 2023
* Update protocol-reference.md with V24 bucket info

Updating from 129 to 62 buckets, per:
nanocurrency/nano-node#3980

Updating from current block balance to max of current or previous, per:
nanocurrency/nano-node#4022

* Update protocol-reference prioritization notable functions

Update protocol-reference.md Election Scheduler section with election_scheduler::activate notable function & adjust wording for pre vs post V24 clarity

* Update protocol reference link to tagged vs develop

Update protocol reference link to a more static tagged release instead of the develop branch (which can change)
@thsfs thsfs added the functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality label Mar 1, 2023
ATXMJ pushed a commit to ATXMJ/nano-community that referenced this pull request Sep 16, 2024
* Update protocol-reference.md with V24 bucket info

Updating from 129 to 62 buckets, per:
nanocurrency/nano-node#3980

Updating from current block balance to max of current or previous, per:
nanocurrency/nano-node#4022

* Update protocol-reference prioritization notable functions

Update protocol-reference.md Election Scheduler section with election_scheduler::activate notable function & adjust wording for pre vs post V24 clarity

* Update protocol reference link to tagged vs develop

Update protocol reference link to a more static tagged release instead of the develop branch (which can change)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants