Add ledger::account_info as interface to access account information #4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
previously approved these changes
Jan 27, 2023
pwojcikdev
reviewed
Jan 27, 2023
| [[maybe_unused]] auto error (ledger.store.account.get (transaction, pending.source, info)); | ||
| debug_assert (!error); | ||
| auto info = ledger.account_info (transaction, pending.source); | ||
| debug_assert (info); |
There was a problem hiding this comment.
I'm wondering whether those asserts inside rollback_visitor & ledger_processor should become release asserts. The check itself is very cheap and the logic it guards is very critical.
pwojcikdev
previously approved these changes
Jan 27, 2023
clemahieu
force-pushed
the
ledger_account_info
branch
from
1e60bd3
to
611b0b5
Compare
…store.account.get. Rather than directly accessing the block store, users should use the ledger interface to query for this information.
…account_store::get. Rather than directly accessing the block store, users should use the ledger interface to query for this information. Result is returned as an std::optional instead of the less-obvious way it's currently reported through an error code. Most though not all of the account_store::get references have been updated to use ledger::account_info.
clemahieu
force-pushed
the
ledger_account_info
branch
from
611b0b5
to
1b24549
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than directly accessing the block store, users should use the ledger::account_info interface to query for account information.
Result is returned as an std::optional instead of the less-obvious way it's currently reported through an error code.
Most though not all of the account_store::get references have been updated to use ledger::account_info.