Fix processing_queue stop
#4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
reviewed
Jan 27, 2023
nano/core_test/processing_queue.cpp
Outdated
| @@ -30,6 +30,8 @@ TEST (processing_queue, process_one) | |||
| ASSERT_TIMELY (5s, processed == 1); | |||
| ASSERT_ALWAYS (1s, processed == 1); | |||
| ASSERT_EQ (queue.size (), 0); | |||
|
|
|||
| queue.stop (); | |||
There was a problem hiding this comment.
I believe these will cause a segfault if the test fails. Since the call to stop is no longer associated with a destructor.
There was a problem hiding this comment.
True, if it fails it will be messy. I added a RAII wrapper that ensures stop will always be called
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deadlocks were possible during node stopping due to invalid stop logic.