Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove the UDP channel implementation from the network #4105

Merged
merged 13 commits into from
Feb 15, 2023
Merged

Remove the UDP channel implementation from the network #4105

merged 13 commits into from
Feb 15, 2023

Conversation

thsfs
Copy link
Contributor

@thsfs thsfs commented Feb 6, 2023 •
edited
Loading

Removes the UDP channel implementation from node's network and some other related code.

Please notice:

  • After this change the only implemented transport layer is TCP.
  • This doesn't remove the UDP option from port mapping.
  • There are still some UDP related code for the endpoints that use boost::asio::ip::udp::endpoint.
  • There are some remaining enumerations related to UDP that should be removed in a further step.
  • This PR depends on Remove UDP support from the peer_container tests #3923 to be merged first.
  • Removes CLI arguments (requires updating the documentation):
    • --disable_udp and --enable_udp
    • --disable_tcp_realtime

Fixes issue: #3846

@thsfs thsfs added the documentation This item indicates the need for or supplies updated or expanded documentation label Feb 6, 2023
@thsfs thsfs added this to the V25.0 milestone Feb 6, 2023
Thiago Silva added 13 commits February 14, 2023 16:07
Remove UDP option from nano::test::system
a43811d
Remove UDP from bootstrap_initiator class
575cb82
Remove UDP cleanups, UDP/TCP conversions from tcp_channels
e76bd4c
Remove peer store of UDP peers
954233e
Remove rep cleanup from UDP inactive channels
294185d
udp_channels doesn't start or stop anymore
8a459e2
Removing the udp_channels from the node's network (part 1)
143eda7
Removing the udp_channels from the node's network (part 2)
8a74795
Removing the udp_channels from the node's network (part 3)
f558254
Removing the udp_channels from the node's network (part 4)
32b9e44
Remove disable_udp flag
5afd261
Remove useless arguments from the CLI
c4d6834 
Removes:
 - disable_udp
 - enable_udp
 - disable_tcp_realtime (TCP cannot be disabled anymore)
Remove nano::transport::transport_type::udp enum
fdffa32
@thsfs thsfs marked this pull request as ready for review February 14, 2023 19:30
@thsfs thsfs added removal Indicates functionality is being removed cli Changes related to the Command Line Interface labels Feb 14, 2023
clemahieu
clemahieu approved these changes Feb 15, 2023
View reviewed changes
nano/node/node.cpp Show resolved Hide resolved
@thsfs thsfs merged commit cd72cc9 into nanocurrency:develop Feb 15, 2023
@thsfs thsfs mentioned this pull request Feb 18, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

@dsiganos dsiganos Awaiting requested review from dsiganos

@pwojcikdev pwojcikdev Awaiting requested review from pwojcikdev

Assignees
No one assigned
Labels
cli Changes related to the Command Line Interface documentation This item indicates the need for or supplies updated or expanded documentation removal Indicates functionality is being removed
Projects
None yet
Milestone
V25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thsfs @clemahieu