Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove UDP test network.self_discard #4107

Merged

Conversation

thsfs
Copy link
Contributor

@thsfs thsfs commented Feb 7, 2023

This test checks a message is not accepted when the sender has the same endpoint of the node. For TCP this is covered by peer_container.no_self_incoming. As we are removing the UDP code, this test is not necessary anymore.

Fixes issue: #3846

@clemahieu clemahieu merged commit 1fcbe63 into nanocurrency:develop Feb 8, 2023
@thsfs thsfs added unit test Related to a new, changed or fixed unit test removal Indicates functionality is being removed labels Mar 1, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
removal Indicates functionality is being removed unit test Related to a new, changed or fixed unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants