Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor election vote #4119

Merged

Conversation

JerzyStanislawski
Copy link
Contributor

Refactoring nano::election::vote method according to #4108.
Main goals:

Reduce nesting of if statements
Use early returns
Simplify longer if statement.

@dsiganos
Copy link
Contributor

Also, that if statement looks like an important one. And it looks like we are missing a test case for it.
Let's add a test case that checks that if statement.

@clemahieu clemahieu merged commit b3f0c53 into nanocurrency:develop Feb 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants