Add LMDB and RocksDB upgrades to v22: Remove unchecked table #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsfs
added
the
database structure
thsfs
reviewed
Apr 17, 2023
thsfs
requested changes
Apr 17, 2023
There was a problem hiding this comment.
For binary compatibility the respective unchecked table handle should be removed as well. This will require some clean up work in the the unchecked_map.?pp and secure/store.?pp files, because they are currently relying on this table to exist even not using it.
Suggest sending another PR for the clean up work before resuming with this.
thsfs
force-pushed
the
clear-unchecked-table
branch
from
1a216cb
to
7549ef9
Compare
clemahieu
reviewed
Apr 25, 2023
thsfs
force-pushed
the
clear-unchecked-table
branch
2 times, most recently
from
ecd1f03
to
865c79f
Compare
clemahieu
reviewed
Apr 25, 2023
In pull request nanocurrency#4021 the binary representation of `unchecked_info` was changed. We have to clear the unchecked table, because the new binary format is not compatible with the old one. This commit only clears the unchecked table for the LMDB implementation. The RocksDB implementation doesn't have an upgrade mechanism yet. - Delete the unchecked DB from the LMDB environment - Simplify the unchecked handle
thsfs
force-pushed
the
clear-unchecked-table
branch
from
b9fae83
to
c7d77ed
Compare
thsfs
changed the title
thsfs
reviewed
May 5, 2023
| generate_tombstone_map (); | ||
| small_table_factory.reset (::rocksdb::NewBlockBasedTableFactory (get_small_table_options ())); | ||
|
|
||
| // TODO: get_db_options () registers a listener for resetting tombstones, needs to check if it is a problem calling it more than once. |
There was a problem hiding this comment.
Encapsulating this to only be called once looks correct.
thsfs
added
the
documentation
clemahieu
approved these changes
May 15, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull request #4021 the binary representation of
unchecked_infowas changed. We have to clear the unchecked table, because the new binary format is not compatible with the old one.This commit only clears the unchecked table for the LMDB implementation. The RocksDB implementation doesn't have an upgrade mechanism yet.