Fix thread names in nano::thread_pool
#4203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread names are very useful to quickly diagnose which threads are causing problems (eg. from htop). However, there were always a few threads whose name was missing, which was caused by buggy
set_thread_names
function. New version uses a counting latch to ensure each thread gets its name assigned, which requires bumping the target macOS version. Generally a thread pool can be implemented by usingboost::io_context
and anano::thread_runner
which would give us much better control of underlying threads and avoid some code duplication, but that is a TODO.