Convert node-wide request rate limiter to a per-channel outstanding request limiter. #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
force-pushed
the
bootstrap_channel_scoring
branch
from
1ed7c33
to
1f7136b
Compare
clemahieu
force-pushed
the
bootstrap_channel_scoring
branch
3 times, most recently
from
6c9f9d6
to
442f0cd
Compare
thsfs
reviewed
Apr 13, 2023
thsfs
reviewed
Apr 13, 2023
thsfs
reviewed
Apr 13, 2023
thsfs
reviewed
Apr 13, 2023
thsfs
reviewed
Apr 13, 2023
thsfs
reviewed
Apr 13, 2023
thsfs
force-pushed
the
bootstrap_channel_scoring
branch
from
02ef3a1
to
23e7268
Compare
thsfs
reviewed
Apr 14, 2023
…equest limiter. Adding prioritizing for selecting channels, picking most responsive channel first.
clemahieu
force-pushed
the
bootstrap_channel_scoring
branch
from
1c83e83
to
8df88cd
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds channel scoring functionality to the ascending bootstrapper. It prioritises using the most responsive channels first, e.g. the channels with the lowest outstanding requests.
Since there is no guarantee requests will be responded to, the scores periodically "decay" when timeouts are calculated.
This scoring opens up future possibilities for additional metrics; an example would be tracking telemetry information and not requesting nodes that report low block counts.
Performance wise this looks to have ~2x improvement over randomly selecting channels as was done previously.