Bootstrap dynamic throttle #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ber of samples it tracks. The number of samples to track is computed in proportion to the number of accounts and blocks in the ledger. This will scale the throttle over time as ledger size adjusts.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability for the bootstrap throttle to dynamically change the number of samples it tracks.
The issue with using a fixed number is it doesn't scale as the ledger scales and particularly causes high CPU usage in unit tests or prematurely stops bootstrapping with the live ledger.
This change dynamically changes the number of tracked samples as the ledger grows.
The formula used for selecting the throttle size is config.throttle_coefficient * sqrt(block_count) and the throttle coefficient uses a default value of 16 which is a good fit based on beta and live testing.