Remove live updating bandwidth limits #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsfs
reviewed
Apr 24, 2023
clemahieu
force-pushed
the
set_bandwidth_params_tsan
branch
from
172fd59
to
35e1360
Compare
…idth_params which was identified as problematic by tsan.
…s according to TSAN. Live config updating was never fully implemented so removing this until a full solution is implemented.
clemahieu
force-pushed
the
set_bandwidth_params_tsan
branch
from
35e1360
to
9fccf32
Compare
thsfs
approved these changes
Apr 24, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live updating of bandwidth parameters was added in #3257 though a thread safety issue with this was identified by TSAN.
Since config reloading was never fully implemented, removing this ability until thread safety can be assured.