Blockprocessor stall workaround #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
approved these changes
May 30, 2023
thsfs
added a commit
to thsfs/nano-node
that referenced
this pull request
May 31, 2023
* Moving from CentOS namig to RHEL compatible * Remove unused build_prep scripts * Update to use RockyLinux 8 as RHEL 8 compatible base Also applies changes to build C++20 (Starting on V25.0) * Add a workflow for beta RPM builds Also fixes the old nanocurrency-beta to build on RockyLinux 8. * Fix nano_node binary name for beta RPM service installation * Blockprocessor stall workaround (nanocurrency#4240) * Remove assert for null block deserialization (nanocurrency#4241) * Bump Qt dep version for Windows build --------- Co-authored-by: Piotr Wójcik <3044353+pwojcikdev@users.noreply.github.com>
clemahieu
pushed a commit
that referenced
this pull request
Jun 2, 2023
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a reported problem with node, where it will hang inside
block_processor::add_blockingfunction. There might be a few different causes for that, however the aim of this PR is to provide a workaround that ensures the node will be able to recover when that problem happens. There are two main changes:block_processor::add_blocking. The timeout after which an error will be reported can be controlled byblock_process_timeoutconfiguration variable. By default it is set to 15 seconds.background_threadsconfiguration variable. It controls how many background threads to spawn for handling long running node RPC commands (including the "process" rpc). By default it is equal to the number of CPU cores, but can be increased by node operators that need additional resiliency.