Encapsulate election mutex #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix issue in notify_observers() where the lock was missing for `auto status = election->status;`
- make use of `set_status_type ()` returning the updated election status
clemahieu
force-pushed
the
prs/encapsulate_election_mutex
branch
from
85bcaae
to
8f1721a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue pointed out by @pwojcikdev introduced in #4306 where in
notify_observers,auto status = election->status;was called without holding the election lock.It makes use of @simpago work of encapsulating the mutex of election class for rsnano.