Multithreaded request aggregator #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems a bit excessive, especially since this is an auxiliary mechanism. We've seen good results even with 2-4 threads allocated. |
|
I have changed it to use max 4 threads as default |
|
You also need to fix the test case "toml.daemon_config_deserialize_defaults" and "daemon_config_deserialize_no_defaults" |
|
Ideally, we want these tests to fail when we forget them, as they are, they not very good. |
It's included now |
pwojcikdev
previously approved these changes
Mar 11, 2024
dsiganos
previously approved these changes
Mar 11, 2024
RickiNano
added a commit
to RickiNano/nano-node
that referenced
this pull request
May 28, 2024
* Run aggregator threaded * Configurable number of aggregator threads * Default to max 4 threads * Added unit test for request_aggregator_threads toml * Improve the description of request_aggregator_threads --------- Co-authored-by: Dimitrios Siganos <dimitris@siganos.org>
RickiNano
added a commit
to RickiNano/nano-node
that referenced
this pull request
May 30, 2024
* Run aggregator threaded * Configurable number of aggregator threads * Default to max 4 threads * Added unit test for request_aggregator_threads toml * Improve the description of request_aggregator_threads --------- Co-authored-by: Dimitrios Siganos <dimitris@siganos.org>
RickiNano
added a commit
to RickiNano/nano-node
that referenced
this pull request
May 30, 2024
* Run aggregator threaded * Configurable number of aggregator threads * Default to max 4 threads * Added unit test for request_aggregator_threads toml * Improve the description of request_aggregator_threads --------- Co-authored-by: Dimitrios Siganos <dimitris@siganos.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made by Colin. I just made it configurable in the config file