Dedicated rep_tiers class
#4471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
reviewed
Mar 8, 2024
nano/node/vote_processor.cpp
Outdated
| representatives_2.clear (); | ||
| representatives_3.clear (); | ||
|
|
||
| auto online = online_reps.online (); |
There was a problem hiding this comment.
I don't think we want to change this from online_reps.trended (). Trended has hysteresis if the network is partitioned or the node is disconnected but online_reps.online doesn't, and might be 0 if the node is disconnected.
There was a problem hiding this comment.
Okay, my goal was for it to be able to react to rep availability changes faster, but thinking about it now, trended makes more sense.
pwojcikdev
force-pushed
the
vote-processor-tiers
branch
from
2eb60ab
to
c36197d
Compare
# Conflicts: # nano/node/node.cpp
pwojcikdev
force-pushed
the
vote-processor-tiers
branch
from
8913d66
to
e62602c
Compare
clemahieu
previously approved these changes
Mar 10, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates calculating representative tiers from vote processor class. Rep tiers will be used for prioritization of vote processing and rebroadcasting.