rep_weights part 1 - Add data store for representative weights #4482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
reviewed
Mar 12, 2024
simpago
force-pushed
the
rep-weight-table
branch
2 times, most recently
from
0746473
to
30a2d04
Compare
pwojcikdev
previously approved these changes
Mar 13, 2024
simpago
force-pushed
the
rep-weight-table
branch
from
30a2d04
to
77440e6
Compare
|
rebased on top of develop |
dsiganos
previously approved these changes
Mar 19, 2024
dsiganos
reviewed
Mar 19, 2024
Representative weights are currently store in memory and loaded from the accounts table when the node starts. Because the number of representatives has grown significantly, we have to store the weights on disk instead. This commit introduces the store class `rep_weight` for storing the rep weights.
simpago
force-pushed
the
rep-weight-table
branch
from
77440e6
to
0f8e2cf
Compare
|
Removed error check when opening rep_weights table |
dsiganos
approved these changes
Mar 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of multiple stacked and self-contained pull requests. The next part is #4483.
Overall Goal
With the recent spam attack the number of representatives has increased significantly. All representatives and their vote weight are held in memory and this isn't a viable solution anymore. This series of pull requests moves the representatives out of memory and stores them in the database.
What this PR does
This PR introduces the store class
rep_weightfor storing the rep weights in the database. The new store is not used yet. This is the basis for the next PR.