Rework handshake visitor #4504
Merged
Rework handshake visitor #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
networking-fixes/handshake-refactor
branch
from
8f91bdf
to
9446617
Compare
pwojcikdev
force-pushed
the
networking-fixes/handshake-refactor
branch
from
9446617
to
3603b5f
Compare
clemahieu
previously approved these changes
Mar 19, 2024
nano/node/transport/tcp_server.cpp
Outdated
| node->logger.debug (nano::log::type::tcp_server, "Handshake query received ({})", nano::util::to_str (server->remote_endpoint)); | ||
| server->handshake_received = true; | ||
|
|
||
| node->logger.debug (nano::log::type::tcp_server, "Handshake query received ({})", fmt::streamed (server->remote_endpoint)); |
There was a problem hiding this comment.
Should this be within if (message.query) since it says it's a query? Or reworded to handshake message?
nano/node/transport/tcp_server.hpp
Outdated
| enum class status | ||
| { | ||
| abort, | ||
| progress, |
There was a problem hiding this comment.
Perhaps "handshake" instead of "progress" to signify what's progressing?
|
Does this include retiring the legacy V1 handshake, and/or should it? |
|
@qwahzi No, it doesn't modify how v1/v2 handshake is handled. |
clemahieu
pushed a commit
to clemahieu/nano-node
that referenced
this pull request
Mar 20, 2024
* Rework tcp_server handshake visitor * Simplify message visitor * Fixes
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.