Fair queuing for request aggregator #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
changed the title
clemahieu
previously approved these changes
May 3, 2024
# Conflicts: # nano/node/nodeconfig.hpp
# Conflicts: # nano/node/request_aggregator.cpp # nano/node/request_aggregator.hpp
# Conflicts: # nano/node/node.cpp # nano/node/request_aggregator.cpp # nano/node/request_aggregator.hpp
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements fair queuing for request aggregator. The benefit is that it removes a small delay that was there due to buffering of requests. This is unnecessary, because client side (
confirmation_solicitorclass) already bundles requests.I believe that the principle of client->server communication should be that the server does the least processing possible. If client requests data inefficiently, then it will just receive less data and fewer resources will be spent servicing them.