Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Output tsv has some minor code duplication issues in find-motif code part. #195

Closed
bgdga opened this issue Jun 2, 2024 · 4 comments
Closed
Labels
bug Something isn't working build-available custom build produced for fix.

Comments

@bgdga
Copy link

bgdga commented Jun 2, 2024

Output tsv has some minor code duplication issues in find-motif code part. It's printing same details 2 times, giving out an error with output after printing just 1st row.
Error message geeting at end of run everytime: "> Error! CSV error: found record with 9 fields, but the previous record has 7 fields"
Please fix it soon. Attaching a screenshot of output tsv for example.

Screenshot from 2024-05-31 15-38-32

@ArtRand
Copy link
Contributor

ArtRand commented Jun 3, 2024

Hello @bgdga,

Could you show me the command you're using so I can debug the problem?

@ArtRand ArtRand added the troubleshooting workflow and data preparation questions label Jun 3, 2024
@bgdga
Copy link
Author

bgdga commented Jun 3, 2024

Using as- modkit find-motifs -o sample_a.tsv --mod-code a --min-sites 10 --min-coverage 20 --in-bedmethyl sample_AC.bed --ref sample.contigs.fasta

@ArtRand
Copy link
Contributor

ArtRand commented Jun 3, 2024

Hello @bgdga,

There is a bug in the current release. Please find a build attached with the fix. The branch includes the code change. I will be sure to release a patch this week including this fix. At your convenience please confirm this build does not produce the error.

Just a heads up that setting --min-sites 10 may increase the search time substantially, if you find this to be the case on other samples try using --skip-search.
modkit_dev1c19442_centos7_x86_64.tar.gz

@ArtRand ArtRand added bug Something isn't working build-available custom build produced for fix. and removed troubleshooting workflow and data preparation questions labels Jun 3, 2024
@bgdga
Copy link
Author

bgdga commented Jun 4, 2024

It's working thankyou.

@bgdga bgdga closed this as completed Jun 4, 2024
ArtRand added a commit that referenced this issue Jun 8, 2024
[bug] use correct row when zero known motifs are provided.

See merge request machine-learning/modkit!186
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working build-available custom build produced for fix.
Projects
None yet
Development

No branches or pull requests

2 participants