Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CF standard name table is outdated #35

Closed
2 tasks done
mortenwh opened this issue Oct 21, 2020 · 1 comment
Closed
2 tasks done

CF standard name table is outdated #35

mortenwh opened this issue Oct 21, 2020 · 1 comment

Comments

@mortenwh
Copy link
Contributor

mortenwh commented Oct 21, 2020

We're using version 30, whereas the latest one is number 76 (https://cfconventions.org/Data/cf-standard-names/current/build/cf-standard-name-table.html).

  • Change to using the Marine Metadata Interoperability Ontology Registry and Repository (https://mmisw.org/ont/cf/parameter) - that should always have the latest version

  • We should note the CF version number and origin (as a uri) in the local copy - see how it is done in gcmd_vocabulary.py

mortenwh added a commit to metno/py-thesaurus-interface that referenced this issue Oct 28, 2020
…n. The problem is that this version does not have metadata about the CF parameter list, such as the CF version number. It seems we have to use the xml instead.
mortenwh added a commit to metno/py-thesaurus-interface that referenced this issue Oct 29, 2020
mortenwh added a commit to metno/py-thesaurus-interface that referenced this issue Oct 29, 2020
mortenwh added a commit to metno/py-thesaurus-interface that referenced this issue Oct 30, 2020
akorosov pushed a commit that referenced this issue Nov 9, 2020
…em is that this version does not have metadata about the CF parameter list, such as the CF version number. It seems we have to use the xml instead.
akorosov pushed a commit that referenced this issue Nov 9, 2020
akorosov pushed a commit that referenced this issue Nov 9, 2020
@akorosov
Copy link
Member

akorosov commented Nov 9, 2020

Closed in #36 by @mortenwh

@akorosov akorosov closed this as completed Nov 9, 2020
akorosov pushed a commit that referenced this issue Nov 20, 2020
* #35: this takes the cf variables from the mmi json version. The problem is that this version does not have metadata about the CF parameter list, such as the CF version number. It seems we have to use the xml instead.

* #35: using RDF/XML instead of RDF/JSON. The latter lacks metadata about the CF parameter list.

* #35: removed invalid comment

* #37: added MMD controlled vocabularies

* #36: removed last entry for MMD. This belongs to #37.

* #37: added tests but they are failing..

* #37: changed dict key to match the one provided in pythesintrc.yaml

* #37: simply continue on KeyError - this data is not relevant for the get functions

* #35: this should solve the issue in python2.7

* GH-39: changes according to beautiful comments from @akorosov!

* #37, GH-39: bug fix

* #37: same error as before (for cf_vocabulary.py) in python 2.7

* #37: added test to get full coverage
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants