Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added static PaymentRequest.canMakePaymentsUsingNetworks method #106

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

ACOSW
Copy link

@ACOSW ACOSW commented Jul 17, 2018

Added static method PaymentRequest.canMakePaymentsUsingNetworks that allows to detect if user has active cards at Apple Pay.

Reference issue: #98

@jimmystridh
Copy link

I'm thinking of the Android behaviour; should it perhaps signal that there is something else going on than those payment types not being unavailable. E.g. resolving undefined or something more clever ?

@ACOSW
Copy link
Author

ACOSW commented Jul 18, 2018

@jimmystridh i thought about it, and now I'm more inclined to opinion that canMakePaymentsUsingNetworks logic should be part of NativePayments.canMakePayments because it does the same thing for android and most likely has an incorrect implementation for iOS.
But on the other side this method should be static because we should have posibility to check payment availability without creation of new PaymenRequest instance. So maybe current PaymentRequest.canMakePaymentsUsingNetworks should be renamed to something like IOScanMakePaymentsUsingNetworks,
Anyway i would like to hear opinion of any of the maintainers about this issue and this pull request, because this functional is very important and it is missing at the moment.

@madoke
Copy link
Contributor

madoke commented Oct 11, 2018

Hi @ACOSW, Thank you for the pull request ! We merged it on our fork at https://github.com/Truphone/react-native-payments

@jimmystridh
Copy link

Hi @madoke, happy to see some activity for this important library. Are you by any chance publishing a version of your fork to NPM?

@madoke
Copy link
Contributor

madoke commented Oct 28, 2018

@jimmystridh yes, we will but it will take some time, I'll let you know when we're ready

sonaye added a commit to ExodusMovement/react-native-payments that referenced this pull request Dec 27, 2019
sonaye added a commit to ExodusMovement/react-native-payments that referenced this pull request Dec 27, 2019
Copy link
Collaborator

@nabilfreeman nabilfreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for your contribution!

@nabilfreeman nabilfreeman merged commit f4d895c into naoufal:master Nov 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants