Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update list of supported Google Pay gateways. #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barbieri
Copy link
Contributor

@barbieri barbieri commented May 5, 2018

There are more gateways, not just braintree and stripe.

@barbieri
Copy link
Contributor Author

barbieri commented May 5, 2018

I had to update the list to use a different gateway, however it may be good to not call validateGateway(), instead let the API be called and return a failure if it's unsupported... this will avoid problems like I had... being more extensible as Google will likely add more partners.

@Andreyco
Copy link
Collaborator

Are these gateways supported by default on Android? No need to setup SDKs for those addons?

@Andreyco Andreyco self-assigned this May 10, 2018
@barbieri
Copy link
Contributor Author

There is no need for an SDK if all you do is to get the reply (ie: paymentToken) and send to your server.

For instance I use firstdata (PayEezy): https://developer.payeezy.com/payeezy-api/apis/post/transactions-18 and its 3DS field is basically what comes in paymentToken:

Payeezy's 3DS:

{
    "signature": "...",
    "type": "G",
    "version": "ECv1",
    "data": "{\"encryptedMessage\":\"...\",\"ephemeralPublicKey\":\"...\",\"tag\":\"...\"}"
  }

React-Native-Payment's getPaymentToken() results:

{
  "signature": "...",
  "protocolVersion": "ECv1",
  "signedMessage": "{\"encryptedMessage\":\"...\",\"ephemeralPublicKey\":\"...\",\"tag\":\"...\"}"
}

@barbieri
Copy link
Contributor Author

ping?

@kirillpisarev
Copy link

This should be merged, otherwise there is no way to integrate almost all gateways from available list as mentioned @barbieri.

@nabilfreeman
Copy link
Collaborator

Hey @barbieri , thanks so much for this PR, especially your follow up comments. I understand that the functionality of Google Pay is pretty different from Apple Pay and this needs a re-think. I'm maintaining this library and studying a bit, will get back to this soon.

@nabilfreeman nabilfreeman added focusing Nabs is focusing on this and removed enhancement labels Nov 19, 2020
@nabilfreeman
Copy link
Collaborator

@kirillpisarev are you around? This was a long time ago but would like to know if this is still the right way to approach supporting gateways for Google Pay.

@kirillpisarev
Copy link

@nabilfreeman i wish i could help you, but i can't remember the point of the issue and i don't have access to the source code of the project i was working on...

@kirillpisarev
Copy link

As far as i remember the supported gateways could be omitted, because the list actually is pretty big and there is no reason to keep it in the code

'payture',
'stripe',
'vantiv',
'worldpay',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkoutltd would be great to be added

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
focusing Nabs is focusing on this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants