This repository has been archived by the owner on Feb 10, 2018. It is now read-only.
Support get_mac_address_table() on L2NG switches #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bkeifer - I had to close #199 (your branch was very old and there were many conflicts, so I gave up and picked your commits).
I have added four more commits to continue your work:
napalm-junos/napalm_junos/junos.py
Lines 1289 to 1290 in c710b0a
junos
namespace should be removed from the input XML: a52a25c.static
field fb4a242 -- I'm not sure where you copied that from.expected_result.json
must be JSON & respect the correct output according to the mocked data you provided: 40da0b4Let me know if you have any questions, I hope my information will help you in the future. Thanks for your PR, this enhancement will be included in the next release, 0.12.1.