Skip to content
This repository has been archived by the owner on Feb 10, 2018. It is now read-only.

Support get_mac_address_table() on L2NG switches #203

Merged
merged 8 commits into from
Sep 18, 2017
Merged

Support get_mac_address_table() on L2NG switches #203

merged 8 commits into from
Sep 18, 2017

Conversation

mirceaulinic
Copy link
Member

@mirceaulinic mirceaulinic commented Sep 5, 2017

Hi @bkeifer - I had to close #199 (your branch was very old and there were many conflicts, so I gave up and picked your commits).

I have added four more commits to continue your work:

  • Because you are looking under two different facts to determine what RPC to execute, see:
    if self.device.facts.get('personality', '') in ['SWITCH']: # for EX & QFX devices
    if self.device.facts.get('switch_style', '') in ['VLAN_L2NG']: # for L2NG devices
    You need both facts specified in the static facts file under the test case: 2868662.
  • The junos namespace should be removed from the input XML: a52a25c.
  • I dropped the static field fb4a242 -- I'm not sure where you copied that from.
  • The expected_result.json must be JSON & respect the correct output according to the mocked data you provided: 40da0b4

Let me know if you have any questions, I hope my information will help you in the future. Thanks for your PR, this enhancement will be included in the next release, 0.12.1.

@mirceaulinic mirceaulinic added this to the 0.12.1 milestone Sep 5, 2017
@coveralls
Copy link

coveralls commented Sep 5, 2017

Coverage Status

Coverage increased (+0.04%) to 78.804% when pulling 40da0b4 on mirceaulinic:mac-l2ng-switches into 3a73f1b on napalm-automation:develop.

@mirceaulinic
Copy link
Member Author

@ktbyers @dbarrosop @bkeifer can you review please?

@dbarrosop
Copy link
Member

Yay! I didn't have to ask for tests ;)

+1

@mirceaulinic mirceaulinic merged commit 50d432d into napalm-automation:develop Sep 18, 2017
@mirceaulinic mirceaulinic deleted the mac-l2ng-switches branch September 18, 2017 08:25
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants