Replace two manual screenshots of the viewer (launch_cli_empty and launch_cli_image) with nbscreenshots #606
+59
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
psobolewskiPhD
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Alternative to: #598
Part of: #568
Needed by: napari/napari#7659
Description
In two places we want to show the outcome of opening the viewer, so the user knows what to expect.
Currently, these are manual screenshots with a CLI in the background and the viewer in the foreground.
Everyones CLI is different and we include the CLI command as a code cell, so I think it's best to just show the viewer.
This makes it one less thing that needs to be manually updated when the viewer GUI changes.