Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Controller integration #11

Merged
merged 22 commits into from
Feb 18, 2024
Merged

Controller integration #11

merged 22 commits into from
Feb 18, 2024

Conversation

Jokilos
Copy link
Contributor

@Jokilos Jokilos commented Jan 10, 2024

Fixed the test and finished module integrating the controller into the app.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (454930d) 97.00% compared to head (913c175) 67.79%.

Files Patch % Lines
..._app_controller/controller/connected_controller.py 27.41% 90 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #11       +/-   ##
===========================================
- Coverage   97.00%   67.79%   -29.21%     
===========================================
  Files           5        7        +2     
  Lines         167      295      +128     
===========================================
+ Hits          162      200       +38     
- Misses          5       95       +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukaszsmolinski lukaszsmolinski mentioned this pull request Jan 25, 2024
lukaszsmolinski

This comment was marked as resolved.

@Jokilos Jokilos closed this Feb 18, 2024
@Jokilos Jokilos reopened this Feb 18, 2024
@Jokilos Jokilos merged commit 3a0c3aa into main Feb 18, 2024
23 checks passed
@Jokilos Jokilos deleted the controller-integration branch February 18, 2024 19:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants