Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove all modifier from napari dependency #110

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Remove all modifier from napari dependency #110

merged 3 commits into from
Nov 10, 2024

Conversation

jni
Copy link
Member

@jni jni commented Nov 8, 2024

Closes #107

@jni jni mentioned this pull request Nov 8, 2024
Merged
@Czaki
Copy link
Collaborator

Czaki commented Nov 8, 2024

You need to fix test setup also to install some qt backend

@jni
Copy link
Member Author

jni commented Nov 8, 2024

Oops! Of course. 😅 Done!

Czaki
Czaki reviewed Nov 8, 2024
View reviewed changes
pyproject.toml Outdated
@@ -36,6 +36,7 @@ testing = [
"pytest>=8.2.0",
"pytest-cov>=5.0.0",
"pytest-qt>=4.0.2",
"PyQt5>=5.13.2,!=5.15.0", # matches napari 0.5.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe napari[all] to avoid synchronisation here?

@jni jni merged commit 597034a into napari:main Nov 10, 2024
10 checks passed
@jni jni deleted the napari-all branch November 10, 2024 01:56
jni added a commit that referenced this pull request Nov 10, 2024
@jni
Use setuptools_scm correctly (#111)
178c886 
Closes #106

I verified locally that it's working:

```
Successfully installed PyQt5-5.15.11 PyQt5-Qt5-5.15.15 PyQt5-sip-12.15.0 midi-app-controller-0.0.13.dev2+gd851237.d20241108
```

(ignore PyQt, this branch didn't include #110 😅)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Czaki Czaki Czaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove [all] from napari[all] in deps
2 participants
@jni @Czaki