Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix creating multiple MIDI interfaces #27

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

lukaszsmolinski
Copy link
Contributor

@lukaszsmolinski lukaszsmolinski commented Mar 13, 2024

The absence of await_return=True in the ensure_main_thread results in it returning a Future, which appears to be the cause of the issue.

I also found a way to convert the midi_callback into a method.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 48.28%. Comparing base (4254c44) to head (a4daf35).
Report is 2 commits behind head on main.

Files Patch % Lines
..._app_controller/controller/connected_controller.py 36.36% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   48.51%   48.28%   -0.24%     
==========================================
  Files          11       12       +1     
  Lines         606      611       +5     
==========================================
+ Hits          294      295       +1     
- Misses        312      316       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jokilos Jokilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lukaszsmolinski lukaszsmolinski requested review from Aleshkev and removed request for Aleshkev March 20, 2024 21:14
@lukaszsmolinski lukaszsmolinski merged commit 03242e8 into main Mar 21, 2024
13 checks passed
@lukaszsmolinski lukaszsmolinski deleted the fix-creating-multiple-midi-interfaces branch March 21, 2024 08:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants