Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove python38 typing #59

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Remove python38 typing #59

merged 7 commits into from
Apr 24, 2024

Conversation

Jokilos
Copy link
Contributor

@Jokilos Jokilos commented Apr 1, 2024

No description provided.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 41.95%. Comparing base (1050d2e) to head (c081e30).

Files Patch % Lines
midi_app_controller/gui/binds_editor.py 0.00% 3 Missing ⚠️
midi_app_controller/gui/midi_status.py 0.00% 1 Missing ⚠️
midi_app_controller/gui/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   42.06%   41.95%   -0.11%     
==========================================
  Files          12       12              
  Lines         718      715       -3     
==========================================
- Hits          302      300       -2     
+ Misses        416      415       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Aleshkev Aleshkev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe these any and callable should be fixed before merging?

@Aleshkev
Copy link
Contributor

Aleshkev commented Apr 3, 2024

Also, maybe we should consider using something like mypy to check if the types are actually correct

@Jokilos Jokilos merged commit f46b5e3 into main Apr 24, 2024
11 checks passed
@Jokilos Jokilos deleted the remove-python38-typing branch April 24, 2024 22:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants