Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Highlight elements in binds editor #68

Merged
merged 13 commits into from
May 8, 2024

Conversation

lukaszsmolinski
Copy link
Contributor

Highlights buttons and knobs in the binds editor when user interacts with them on a controller.

Depends on #66 and should be merged after it.

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 6.31579% with 89 lines in your changes are missing coverage. Please review.

Project coverage is 38.16%. Comparing base (c620dbc) to head (a46d661).

Files Patch % Lines
midi_app_controller/gui/binds_editor.py 0.00% 66 Missing ⚠️
..._app_controller/controller/connected_controller.py 16.00% 21 Missing ⚠️
midi_app_controller/gui/midi_status.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   40.35%   38.16%   -2.19%     
==========================================
  Files          14       14              
  Lines         969     1035      +66     
==========================================
+ Hits          391      395       +4     
- Misses        578      640      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Aleshkev Aleshkev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is now, it crashes when saving binds

@lukaszsmolinski lukaszsmolinski requested review from Aleshkev and removed request for Aleshkev May 3, 2024 16:36
Base automatically changed from synchronize-buttons to main May 7, 2024 21:43
@lukaszsmolinski lukaszsmolinski merged commit 215c486 into main May 8, 2024
11 checks passed
@lukaszsmolinski lukaszsmolinski deleted the highlight-elements-in-binds-editor branch May 8, 2024 22:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants