Gui improvement #73

modyf01 · 2024-05-05T09:53:38Z

No description provided.

codecov · 2024-05-05T09:54:13Z

Codecov Report

Attention: Patch coverage is 22.85714% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 37.65%. Comparing base (da2dfa9) to head (e7bc1ae).

Files	Patch %	Lines
midi_app_controller/gui/binds_editor.py	0.00%	47 Missing ⚠️
midi_app_controller/state/state_manager.py	0.00%	5 Missing ⚠️
..._app_controller/controller/connected_controller.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   38.23%   37.65%   -0.59%     
==========================================
  Files          14       14              
  Lines        1033     1049      +16     
==========================================
  Hits          395      395              
- Misses        638      654      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

midi_app_controller/gui/utils.py

midi_app_controller/gui/binds_editor.py

midi_app_controller/gui/utils.py

midi_app_controller/models/binds.py

midi_app_controller/state/state_manager.py

requirements-test.txt

midi_app_controller/actions/_tests/test_bound_controller.py

midi_app_controller/gui/binds_editor.py

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

initial commit

bec0a3d

modyf01 requested review from lukaszsmolinski, Aleshkev and Jokilos May 5, 2024 09:53

lukaszsmolinski suggested changes May 5, 2024

View reviewed changes

This comment was marked as resolved.

# to view

modyf01 added 2 commits May 5, 2024 15:44

small improvements in gui and updated pydantic version

01a5139

small improvements in gui and updated pydantic version

e6ccd6c

Aleshkev reviewed May 5, 2024

View reviewed changes

midi_app_controller/gui/utils.py Show resolved Hide resolved

lukaszsmolinski suggested changes May 5, 2024

View reviewed changes

midi_app_controller/models/binds.py Outdated Show resolved Hide resolved

midi_app_controller/state/state_manager.py Outdated Show resolved Hide resolved

requirements-test.txt Outdated Show resolved Hide resolved

modyf01 changed the title ~~initial commit~~ Gui improvement May 5, 2024

modyf01 added 2 commits May 7, 2024 17:47

pydantic migration

c34d1aa

pydantic migration

10960d5

modyf01 requested review from lukaszsmolinski and Aleshkev May 7, 2024 16:02

lukaszsmolinski suggested changes May 7, 2024

View reviewed changes

midi_app_controller/actions/_tests/test_bound_controller.py Show resolved Hide resolved

midi_app_controller/gui/binds_editor.py Outdated Show resolved Hide resolved

change to qtpy

1cb844d

modyf01 requested a review from lukaszsmolinski May 8, 2024 03:57

pre-commit-ci bot and others added 3 commits May 8, 2024 06:07

[pre-commit.ci] pre-commit autoupdate (#74)

0f4cec5

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Synchronize buttons (#66)

65249ed

Add more napari actions (#67)

4b66622

lukaszsmolinski approved these changes May 8, 2024

View reviewed changes

Aleshkev approved these changes May 8, 2024

View reviewed changes

Merge branch 'main' into guiimprovement

e7bc1ae

lukaszsmolinski merged commit 50fc09c into main May 8, 2024
11 checks passed

lukaszsmolinski deleted the guiimprovement branch May 8, 2024 22:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gui improvement #73

Gui improvement #73

modyf01 commented May 5, 2024

codecov bot commented May 5, 2024 •

edited

Loading

This comment was marked as resolved.

Gui improvement #73

Gui improvement #73

Conversation

modyf01 commented May 5, 2024

codecov bot commented May 5, 2024 • edited Loading

Codecov Report

This comment was marked as resolved.

codecov bot commented May 5, 2024 •

edited

Loading