Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Footer clings to body between 1150-1425px #89

Closed
tlambert03 opened this issue Mar 16, 2022 · 6 comments
Closed

Footer clings to body between 1150-1425px #89

tlambert03 opened this issue Mar 16, 2022 · 6 comments
Labels
bug Something isn't working P3

Comments

@tlambert03
Copy link
Contributor

Untitled

@tlambert03 tlambert03 added the bug Something isn't working label Mar 16, 2022
@codemonkey800
Copy link
Contributor

This should be fixed in https://github.com/napari/napari-sphinx-theme/releases/tag/v0.1.0, could you check again please? 😄 We may have to redeploy because I just released today

@tlambert03
Copy link
Contributor Author

tlambert03 commented Mar 21, 2022

still there on https://napari.org/usage.html ... will check tomorrow or after next docs deploy

@jni
Copy link
Member

jni commented Mar 22, 2022

Note that deploy docs can be manually triggered by maintainers here:

https://github.com/napari/napari/actions/workflows/deploy_docs.yml

Just triggered a build, can't wait any longer, anticipation is killing me 😂

@jni
Copy link
Member

jni commented Mar 22, 2022

Well, it's not clinging anymore (if I understand the issue correctly), but something funky still going on...

Screen.Recording.2022-03-22.at.1.39.31.pm.mov

This is FF 97.0.1 on macOS 11.4. I presume the "correct" behavior is that the footer bar should align exactly (no scrolling) with the bottom of the window if it fits?

@codemonkey800
Copy link
Contributor

hmm, i probably need to do some CSS calculations for the height then because this is a seemingly standard way of pushing the footer to the bottom: https://stackoverflow.com/questions/4575826/how-to-push-a-footer-to-the-bottom-of-page-when-content-is-short-or-missing

but the side effect is, as you've found, that the footer is pushed past the viewport and requires scrolling. i'll see what can be done, maybe doing something like calc(100vh - footer-height) will work

codemonkey800 added a commit that referenced this issue Jun 29, 2022
* #109 Fix video width

* #93 Fix pagination buttons overflow

* #89 Fix footer pushed outside viewport

* #79 Fix highlight correct in-page TOC item
@codemonkey800 codemonkey800 added P3 and removed P1 labels Jul 8, 2022
@psobolewskiPhD
Copy link
Member

The disappearing footer is fixed with #134

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working P3
Projects
None yet
Development

No branches or pull requests

4 participants