Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add fail soft option to store valid temperature #35

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

narugit
Copy link
Owner

@narugit narugit commented Aug 17, 2024

About

@narugit narugit force-pushed the feature/add_fail_soft_option branch from 02642bc to 46f54c7 Compare August 17, 2024 13:10
@narugit
Copy link
Owner Author

narugit commented Aug 17, 2024

Hi @kyleyannelli
I've added fail soft option which I've described in #34 (comment)
Could you try this branch on your PC?

@kyleyannelli
Copy link
Contributor

╭─kyannelli::mbp @ ~/smctemp/narugit
╰─ » ./smctemp -c -n1000 -f                                                                                                                                                                    1 ↵
35.4
Time: 0h:00m:04s

╭─kyannelli::mbp @ ~/smctemp/narugit
╰─ » cat /tmp/smctemp/cpu_temperature.txt
35.3717

LGTM

@narugit narugit force-pushed the feature/add_fail_soft_option branch from 46f54c7 to ffea714 Compare August 17, 2024 13:55
@narugit
Copy link
Owner Author

narugit commented Aug 17, 2024

@kyleyannelli
Thank you for quick check!
But sorry, I've updated the code, so could you kindly test again?

@narugit
Copy link
Owner Author

narugit commented Aug 17, 2024

@kyleyannelli
Is smctemp work when you could not get valid temperature value?

$ smctemp -c -n1000 -f

↓This would read last valid temperature from /tmp/ because it would fail to get valid temperature
$ smctemp -c -n1 -f 

@narugit narugit force-pushed the feature/add_fail_soft_option branch from ffea714 to d9ee49a Compare August 17, 2024 14:04
@kyleyannelli
Copy link
Contributor

@narugit Yes, it works. Thanks!

@narugit narugit merged commit 1c3d3cb into main Aug 18, 2024
2 checks passed
@narugit narugit deleted the feature/add_fail_soft_option branch August 18, 2024 00:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants