Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix double slash #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JustFly1984
Copy link

I've started to use your project to generate sitemap.xml for my remix app, and I've noticed that there is // in urls in generated sitemap. I had inlined all the code from your package into my project and found the place where double / sneaks in.

example of how it was:

<loc>https://exaple.com//sign-up-with-github</loc>

how it is fixed:

<loc>https://exaple.com/sign-up-with-github</loc>

@lpsinger
Copy link
Member

This definitely needs unit tests. Would you care to adapt them from #11?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants