You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
function header comments which include the function name
Another minor issue has to do with empty lines:
a) unnecessary empty lines (e.g. first line after the opening brace of a function/struct, or the last line before the closing brace - the latter apparently sometimes triggers the CI checks).
b) missing empty lines between functions (i.e. closing brace of last function, then next function beginning on the immediately next line without an empty line in between)
The unnecessary empty lines (at the beginning or end of a function, for example) represent a low single-digit percentage of the cases (the vast majority of functions/structs do not have these extra empty lines), so there is an argument to remove them purely for consistency, not just due to them being redundant.
Expected behavior
Remove redundant comments to reduce clutter and inconsistency in the code, and improve readability.
The text was updated successfully, but these errors were encountered:
thnkslprpt
changed the title
Redundant comments (/* end of function */, /* end if */ etc.)
Redundant comments (/* end of function */, /* end if */ etc.) and out-of-place empty lines.
Oct 5, 2022
thnkslprpt
changed the title
Redundant comments (/* end of function */, /* end if */ etc.) and out-of-place empty lines.
Redundant comments (/* end of function */, /* end if */ etc.) and clean up empty lines.
Oct 5, 2022
Checklist
Describe the bug
Copy of nasa/to_lab#68 and nasa/sample_app#111
There are quite a few redundant comments in the code, such as:
/* end of function */
-type comments/* end if */
-type commentsAnother minor issue has to do with empty lines:
a) unnecessary empty lines (e.g. first line after the opening brace of a function/struct, or the last line before the closing brace - the latter apparently sometimes triggers the CI checks).
b) missing empty lines between functions (i.e. closing brace of last function, then next function beginning on the immediately next line without an empty line in between)
The unnecessary empty lines (at the beginning or end of a function, for example) represent a low single-digit percentage of the cases (the vast majority of functions/structs do not have these extra empty lines), so there is an argument to remove them purely for consistency, not just due to them being redundant.
Expected behavior
Remove redundant comments to reduce clutter and inconsistency in the code, and improve readability.
Reporter Info
@thnkslprpt
The text was updated successfully, but these errors were encountered: